search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

korken89's J-Link fix behind a feature flag #39

Closed nickray closed 5 years ago

nickray commented 5 years ago

In response to https://github.com/rust-embedded/cortex-m-semihosting/issues/38 I suggest picking up https://github.com/rust-embedded/cortex-m-semihosting/pull/35 again.

@korken89 since you observed -1, -2, -3, maybe n > 0xffff_fff0 is a good condition instead of catching just "-1"? As I understand it, worst case some very long outputs get truncated.

I did send an email to Segger support (would be good if these special cases were a finite list, and documented in UM08001), but who knows if they will answer :)

rust-highfive commented 5 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

bors[bot] commented 5 years ago

Build succeeded