search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Make HStdout and HStderr Copy. #40

Closed m-ou-se closed 5 years ago

m-ou-se commented 5 years ago

This makes it possible to pass it around by value, use a Cell<HStdout>, etc.

rust-highfive commented 5 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

m-ou-se commented 5 years ago

This only makes sense because the crate doesn't close() the streams. Do we want to implement calling close() on drop at some point? If so, this shouldn't be merged.

adamgreig commented 5 years ago

I don't see why we'd need to call close(), and anyway if we do it just means the writes on the other instances will start failing with errors, which isn't unsafe. Personally I'm in favour of this PR but I'll give other @rust-embedded/cortex-m people a chance to chime in since it's a bit of a semantic change.

bors[bot] commented 5 years ago

Build succeeded