search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Merge HStdout and HStderr into the same type #41

Closed m-ou-se closed 3 years ago

m-ou-se commented 5 years ago

They were exactly the same anyway. Now it is easier to pass either stdout or stderr to a function, for example.

rust-highfive commented 5 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

adamgreig commented 5 years ago

I like this change but it is a breaking change so would require a 0.4 release.

adamgreig commented 5 years ago

My feeling is we merge #42 and #40 and release 0.3.5, then merge this and prepare for 0.4.0.

adamgreig commented 3 years ago

This is now merged in https://github.com/rust-embedded/cortex-m/pull/269, the new location of this crate.