search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Add equivalent of dbg! macro #42

Closed nickray closed 5 years ago

nickray commented 5 years ago

I think this would be quite useful. Thoughts?

Maybe it would be better for dbg! to be in core with somehow switchable implementation (semihosting, vcom, etc.), but I don't know how to approach that.

Added CHANGELOG also for the missing one for https://github.com/rust-embedded/cortex-m-semihosting/pull/39

Perhaps some more documentation is needed?

nickray commented 5 years ago

Added an example as documentation.

bors[bot] commented 5 years ago

Build failed

adamgreig commented 5 years ago

Looks like we'll need to edition-2018ify this crate first.

nickray commented 5 years ago

Interesting, I see no compilation errors (also explicitly setting 2015 edition), and successfully link into a 2018 edition example. Does Travis have some sort of strict mode? Or maybe it's because I use 1.37.

I assume the edition update should be a separate request, right? If I go at it, anything I need to consider besides making it compile?

nickray commented 5 years ago

Hehe, adding stable thumbv8m testing fixed https://travis-ci.org/rust-embedded/cortex-m-semihosting/jobs/575372081

adamgreig commented 5 years ago

We should probably mention edition2018 in the changelog but we can add that after.

bors[bot] commented 5 years ago

Build succeeded