search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Add MSRV 1.33.0 to CI #53

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

See: https://github.com/rust-embedded/wg/issues/445

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

therealprof commented 4 years ago

1.32 doesn't seem to do it for armv8

therealprof commented 4 years ago

cf. https://travis-ci.org/github/rust-embedded/cortex-m-semihosting/jobs/677848641

eldruin commented 4 years ago

Ok. Support for armv8 was added in Rust 1.33.0. Now the nightly build broke due to the combination of using deprecated macro asm! and having #[deny(warnings)] but this can be solved in a separate PR.

therealprof commented 4 years ago

Yes, not worried about nightly at this point.

therealprof commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded: