search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Code formatting #54

Closed eldruin closed 3 years ago

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

thejpster commented 4 years ago

Looks good, but I wonder if we should enforce this in CI to avoid subsequent PRs diverging from the rustfmt standard.

eldruin commented 4 years ago

@thejpster Sure thing. I added the check now.

therealprof commented 4 years ago

We're planning to use more GitHub Actions for CI and these kind of checks. Maybe it would make more sense to go straight to GHA instead of using Travis for a short bit?

Adding it should be as simple as copying these two workflows: https://github.com/rust-embedded/svd2rust/tree/master/.github/workflows

therealprof commented 4 years ago

Well, wrong example. The CI workflow is the wrong one. ;) This should hit the spot better: https://github.com/stm32-rs/stm32f1xx-hal/blob/master/.github/workflows/rustfmt.yml

eldruin commented 4 years ago

@therealprof Sure. GHA are quite nice. I added only the formatting check for now. Building CI could be done in a separate PR.

therealprof commented 4 years ago

bors r+

therealprof commented 4 years ago

Hm, bors crashed on this. Let's try again.

bors merge

eldruin commented 4 years ago

@therealprof bors has been having a couple rough days. Could you try again?

korken89 commented 4 years ago

bors retry

korken89 commented 4 years ago

bors cancel

korken89 commented 4 years ago

bors r+

adamgreig commented 3 years ago

Thanks for the PR, and sorry bors never quite managed to merge it... we've now moved this crate to the cortex-m repository. We could consider adding rustfmt over there to the whole repository, but I'm closing the PR here.