search

rust-embedded / cortex-m-semihosting

Semihosting for ARM Cortex-M processors
Apache License 2.0
40 stars 19 forks source link

Remove #[deny(warnings)] #56

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

#[deny(warnings)] is considered an anti-pattern.

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jonas-schievink commented 4 years ago

If we do this, we should set -Dwarnings in CI so that we don't merge code with warnings

eldruin commented 4 years ago

@jonas-schievink good point. It is done now.

bors[bot] commented 4 years ago

Build succeeded: