Closed japaric closed 4 years ago
so there are may be more errors similar to this one in the crate
The crate certainly compiles once I configure out the basepri stuff.
As removing an API is a breaking-change (it breaks libraries...
I can certainly vouch that it breaks rtfm :)
I think this can be closed now, reopen if the issue persists
STR
Grab the cortex-m-quickstart template (a version that uses cortex-m v0.6.0) and compile this program:
for the
thumbv8m.base-none-eabi
target but make sure that the "inline-asm" feature of cortex-m has been enabled; you get:The BASEPRI register doesn't exist on ARMv8-M devices that don't have the main extension. The
register::{basepri,basepri_max,faultmask}
APIs should not be exposed for thethumbv8m.base-none-eabi
target.As removing an API is a breaking-change (it breaks libraries; the above error only occurs in applications) I would suggest marking the API as deprecated on the
thumbv8m.base-none-eabi
target and removing it in the next minor version.This API should not be removed from the
thumbv8m.main-none-eabi*
targets (note: main, not base) as it is supported on those devices.Metadata
I also noted that the
thumbv8m.base-none-eabi
target is not being tested on Travis and that it doesn't have special handing (cargo:rustc-cfg
) in thebuild.rs
so there are may be more errors similar to this one in the crate.