search

rust-embedded / discovery

Discover the world of microcontrollers through Rust!
https://docs.rust-embedded.org/discovery/
Apache License 2.0
1.47k stars 510 forks source link

Some images should be stored locally and imported in html page #487

Open Jzow opened 1 year ago

Jzow commented 1 year ago

Question:

For the gh-pages branch, some images are imported from Wikipedia. However, when we translate the book, some images cannot be loaded successfully in some regions due to vpn.

Example:

Picture of index.html in Chapter 10

Idea:

This is my personal idea, not everything. We can create an image folder under each chapter to store the downloaded images. The html page can be imported through the relative path.

I hope it will be better for users to read this book

eldruin commented 1 year ago

I see the problem. However, I am unsure about the copyright issues since each image has a specific license, author and so on. Any idea how to solve this?

Jzow commented 1 year ago

My previous practice was to indicate the source of the picture, except for the pictures published by Wikipedia.

The 《discovery book》 was not used for commercial purposes, and it will not damage the author's reputation, property and rights.

But he may have legal problems. I think we can pause until there is a better idea.