rust-embedded / embedded-hal

A Hardware Abstraction Layer (HAL) for embedded systems
Apache License 2.0
2.01k stars 202 forks source link

spi/blocking: Add word methods and default impls that use them #374

Closed GrantM11235 closed 2 years ago

GrantM11235 commented 2 years ago

This will also allow us to add new methods in the future with default implementations as a non-breaking change.

rust-highfive commented 2 years ago

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

Dirbaio commented 2 years ago

I'm not convinced the _word variants are useful.

This will also allow us to add new methods in the future with default implementations as a non-breaking change.

Why is that not the case already, with the current slice-based methods?

eldruin commented 2 years ago

I share @Dirbaio's analysis. I would rather not increase the API surface if there is no very good reason for it. Could you elaborate what that would be?

GrantM11235 commented 2 years ago

As discussed in the meeting, I find the arguments against these methods to be convincing.