Closed newAM closed 2 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eldruin (or someone else) soon.
Please see the contribution instructions for more information.
LGTM, could you do the same change to async's docs ?
LGTM, could you do the same change to async's docs ?
Good call. Made the change & rebased.
Should I add a changelog entry for this? I wasn't sure because it doesn't change anyone's impl.
IMO it's small enough that no changelog is fine, but feel free to add it if you want.
Currently the
SpiDevice
trait does not define the sequence of actions that occur after a bus error.I discussed this with @Dirbaio in the matrix chat and the conclusion we reached was that this should be added to the documentation as a guideline to match what already exists for
ExclusiveDevice
. The rationale for a guideline instead of a requirement is that SPI error recovery is implementation specific.