search

rust-embedded / embedded-hal

A Hardware Abstraction Layer (HAL) for embedded systems
Apache License 2.0
2.01k stars 202 forks source link

Use github action dtolnay/rust-toolchain@master instead of actions-rs #439

Closed jannic closed 1 year ago

jannic commented 1 year ago

actions-rs/toolchain@v1 uses deprecated features and has not been updated for years

Dirbaio commented 1 year ago

The base GHA ubuntu image already contains rustup. I wonder if we could use that, with just shell commands to set the right rust version. What are the advantages of using a dedicated action?

jannic commented 1 year ago

The base GHA ubuntu image already contains rustup. I wonder if we could use that, with just shell commands to set the right rust version. What are the advantages of using a dedicated action?

I think the action applies some optimizations regarding github caching etc., but I don't know any details. That's just the minimal change I found to avoid the deprecation warnings.

bors[bot] commented 1 year ago

Build succeeded: