ci: simplify, test MSRV.

rust-embedded / embedded-hal

A Hardware Abstraction Layer (HAL) for embedded systems

Apache License 2.0

2.01k stars 202 forks source link

ci: simplify, test MSRV. #545

Closed Dirbaio closed 11 months ago

Dirbaio commented 11 months ago

Do two MSRV tests, for 1.60 and 1.75
1.75 uses beta for now, will change after it's released.
Use separate jobs instead of matrix. The Github Actions matrix is very cursed, especially if you use include. We don't have that many combinations, IMO doing separate jobs is way more straightforward and only slightly more verbose.
embedded-hal needs rust-version = 1.60 because it uses dep:.

Fixes #538

Dirbaio commented 11 months ago

needs updating repo settings, will do after PR approval.

eldruin commented 11 months ago

I have already updated the branch protection rules as these needed to be updated before the merge. Otherwise some required builds were missing.

eldruin commented 11 months ago

Now we are missing a build without features, though. That might be a good addition.

Dirbaio commented 11 months ago

Now we are missing a build without features, though. That might be a good addition.

the test job is doing a test without features, which should already build all crates without features. (or is there some scenario where test succeeds but build can fail?)

eldruin commented 11 months ago

Ah, I missed that. Thank you!