e-h-bus/spi: Require infallible chipselect pins

rust-embedded / embedded-hal

A Hardware Abstraction Layer (HAL) for embedded systems

Apache License 2.0

1.95k stars 197 forks source link

e-h-bus/spi: Require infallible chipselect pins #574

Open GrantM11235 opened 8 months ago

GrantM11235 commented 8 months ago

Fixes #573

[x] Require infallible chipselect pins
[x] Add an unwrapping adapter
- [ ] Think of a good name for the adapter
[x] Add documentation
[x] Update changelog

GrantM11235 commented 8 months ago

The docs and changelog are done. I am open to suggestions for the name of UnwrappingAdapter if anyone has any better ideas, but I think it is okay as it is.

This PR was brought up at the meeting today, but no one had much to say about it. I assume that means there are no strong objections.

Dirbaio commented 7 months ago

i'm personally 50/50 on this. The tradeoffs are subtle and i'm not sure which side of them is the best. So I won't merge this myself but I'm OK with merging if other people in the HAL team are in favor.