search

rust-embedded / embedded-hal

A Hardware Abstraction Layer (HAL) for embedded systems
Apache License 2.0
2.02k stars 202 forks source link

Don't recommend supporting eh0.2 #640

Closed MabezDev closed 3 days ago

MabezDev commented 3 days ago

This PR changes the recommendation to add 0.2 impls into HALs.

It keeps the instructions but modifies them slightly to put it behind a feature so that we don't recommend third party HALs violate C-STABLE. How important C-STABLE is for trait implementations is debatable but I still don't think we, as a rust working group, should be recommending use of a 0.2 version of a crate when a 1.0 exists.

Alternatives

We remove this section completely and leave it to HAL authors

Rahix commented 3 days ago

I think it's also worth bringing https://github.com/ryankurte/embedded-hal-compat into this.

MabezDev commented 3 days ago

I think it's also worth bringing ryankurte/embedded-hal-compat into this.

It's mentioned in the next section, unless you meant to include it in this section as well?