search

rust-embedded / embedonomicon

How to bootstrap support for a no_std target
https://docs.rust-embedded.org/embedonomicon/
Apache License 2.0
206 stars 33 forks source link

Add triagebot configuration #65

Open LeSeulArtichaut opened 4 years ago

LeSeulArtichaut commented 4 years ago

This enables assignment through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

bors[bot] commented 4 years ago

Build failed:

jamesmunns commented 4 years ago

Hey @jonas-schievink, this is complaining about a change in generated assembly code. Is this due to the "don't mangle the LR when panicking" change? Should we fix the expected generated ASM here?

jonas-schievink commented 4 years ago

Looks like it, yeah

jamesmunns commented 4 years ago

Note: will probably need to be rebased on https://github.com/rust-embedded/embedonomicon/pull/66