Closed robyoung closed 3 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.
Please see the contribution instructions for more information.
That's great. Thanks for the review. I'll take a look at it later today.
@adamgreig I have tried to follow the other book repos as much as possible. However, it looks like this repo does a bit more testing so it feels like it needs to be tested across different versions of rust, which the other workflows do not.
Canceled.
Ugh, that's enough whack-a-mole for tonight. Please don't be put off, this is mostly the test script needing some updates for the latest version of nm
. The usual game of fixing one CI bug and then finding the next... If you can work out why arm-none-eabi-gcc isn't being found even though it's apparently installed please go ahead, but otherwise I'll try again tomorrow.
Whew, that was an endeavour. It turns out you can't copy arm-none-eabi-gcc into a new directory, it needs to stay relative to the directory structure it was extracted from. Who knew.
bors merge
:-1: Rejected by too few approved reviews
bors cancel
Canceled.
Build succeeded:
:tada: thanks @robyoung!
Woop! Thank you for fixing it. I was totally stumped.
I have tried to keep it functionally identical to the travis workflow. This is a bit tricky for me to test.
There are some minor changes though.