rust-embedded / embedonomicon

How to bootstrap support for a no_std target
https://docs.rust-embedded.org/embedonomicon/
Apache License 2.0
206 stars 33 forks source link

Switch to using GitHub Actions for CI #72

Closed robyoung closed 3 years ago

robyoung commented 3 years ago

I have tried to keep it functionally identical to the travis workflow. This is a bit tricky for me to test.

There are some minor changes though.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

Please see the contribution instructions for more information.

robyoung commented 3 years ago

That's great. Thanks for the review. I'll take a look at it later today.

robyoung commented 3 years ago

@adamgreig I have tried to follow the other book repos as much as possible. However, it looks like this repo does a bit more testing so it feels like it needs to be tested across different versions of rust, which the other workflows do not.

bors[bot] commented 3 years ago

Canceled.

adamgreig commented 3 years ago

Ugh, that's enough whack-a-mole for tonight. Please don't be put off, this is mostly the test script needing some updates for the latest version of nm. The usual game of fixing one CI bug and then finding the next... If you can work out why arm-none-eabi-gcc isn't being found even though it's apparently installed please go ahead, but otherwise I'll try again tomorrow.

adamgreig commented 3 years ago

Whew, that was an endeavour. It turns out you can't copy arm-none-eabi-gcc into a new directory, it needs to stay relative to the directory structure it was extracted from. Who knew.

bors merge

bors[bot] commented 3 years ago

:-1: Rejected by too few approved reviews

adamgreig commented 3 years ago

bors cancel

bors[bot] commented 3 years ago

Canceled.

bors[bot] commented 3 years ago

Build succeeded:

adamgreig commented 3 years ago

:tada: thanks @robyoung!

robyoung commented 3 years ago

Woop! Thank you for fixing it. I was totally stumped.