rust-embedded / embedonomicon

How to bootstrap support for a no_std target
https://docs.rust-embedded.org/embedonomicon/
Apache License 2.0
206 stars 33 forks source link

Typo in cargo objdump argument #75

Closed perlindgren closed 2 years ago

perlindgren commented 2 years ago

Found a small typo in memory-layout.md

cargo objdump --bin app -- -s -section .vector_table

should read

cargo objdump --bin app -- -s --section .vector_table
rust-highfive commented 2 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

Please see the contribution instructions for more information.

adamgreig commented 2 years ago

Thanks! This isn't strictly a typo - binutils used to accept single dashes for flags like this, but recent versions require two dashes instead, so a lot of older rust-embedded documentation and tools have needed updating over the last year or so. There might be other instances in the embedonomicon too...

Unfortunately our CI is also broken right now (see #74) because of the tools updating changing the output format, so the tests no longer pass... it will need a bit of updating I guess.

bors[bot] commented 2 years ago

Build succeeded: