Add `Deque::{swap, swap_unchecked, swap_remove_front, swap_remove_back}`

rust-embedded / heapless

Heapless, `static` friendly data structures

Apache License 2.0

1.56k stars 185 forks source link

Add `Deque::{swap, swap_unchecked, swap_remove_front, swap_remove_back}` #508

Closed honzasp closed 3 weeks ago

honzasp commented 3 months ago

These methods are equivalent to their std counterparts (except swap_unchecked(), which is a natural extension).

honzasp commented 3 months ago

I fixed the Miri error in CI, there remain some errors from Clippy, which are however not caused by this PR: it seems that a new version of Clippy flags new errors.

jannic commented 1 month ago

The clippy warnings have been fixed in the mean time (#512). Could you rebase your PR?

jannic commented 1 month ago

We discussed this in today's matrix meeting and the response was positive. So @honzasp, if you rebase this, I'm sure it will be approved soon.

honzasp commented 3 weeks ago

@jannic Rebased and all checks passed :tada: