search

rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
236 stars 40 forks source link

Move to digital v2 traits #18

Closed dbrgn closed 5 years ago

dbrgn commented 5 years ago

The v1 traits are deprecated because they don't have a way to report errors.

Gets rid of the deprecation warnings (which are hard errors until #17 is merged).

rust-highfive commented 5 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

dbrgn commented 5 years ago

Rebased against master, the build should now succeed (since #17 was merged).

rnestler commented 5 years ago

@ryankurte Is there a bors trigger needed?

nastevens commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build succeeded