Closed eldruin closed 4 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Closing. I think a patch release may be enough.
bors try
(not sure if this is mergeable or needs update due to merging #26)
bors r+
@ryankurte Thanks for reviewing and merging :) Could you also create a tag and publish to crates.io?
aand done, had to sleep and wanted to quickly test it all first. thanks for all your work (and patience)!
I updated the changelog with everything that happened since the 0.2.2 release and bumped the minor version because of the digital::v2. I also fixed setting the embedded-hal version to 0.2.3 because that is when the digital::v2 traits were released. This branch sits on top of #26 with the hopeful date of today :)