search

rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
236 stars 40 forks source link

Document MSRV 1.32.0 and test it on CI #41

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

See: https://github.com/rust-embedded/wg/issues/445

rust-highfive commented 4 years ago

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

posborne commented 4 years ago

Thanks @eldruin, sorry for the delay in review.

posborne commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build failed:

eldruin commented 4 years ago

Hmm, it does not compile on 1.32.0 due to gpio_cdev pulling in error-chain, which pulls in backtrace, which has a MSRV of 1.40.0. With 1.40.0 it builds fine but it is quite a jump. Do you want to pull this or do something about those dependencies?

adamgreig commented 4 years ago

Ping @rust-embedded/embedded-linux, perhaps we could get this merged even at 1.40.0?

posborne commented 4 years ago

@eldruin There's a new version of gpio_cdev published that drops error-chain which would be another option, but I have no problem with moving to 1.40.0 for the MSRV here either.

eldruin commented 4 years ago

@posborne sounds good. Using gpio-cdev 0.3 we how have a MSRV of 1.36.0. Closing in favor of #42