search

rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
236 stars 40 forks source link

Update gpio-cdev to 0.4.0 and add async-tokio feature #55

Closed dfrankland closed 3 years ago

dfrankland commented 3 years ago

It'd be lovely to allow streaming of chip line events asynchronously now that gpio-cdev supports it.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ryankurte commented 3 years ago

lgtm, thanks!

bors r+

bors[bot] commented 3 years ago

:-1: Rejected by too few approved reviews

bors[bot] commented 3 years ago

Timed out.

ryankurte commented 3 years ago

...

bors retry

bors[bot] commented 3 years ago

Timed out.

eldruin commented 3 years ago

Thanks @dfrankland. Could you rebase this to master now that we switched to GitHub Actions instead of Travis?

dfrankland commented 3 years ago

My apologies, I just got back from a holiday. This PR is rebased now.

dfrankland commented 3 years ago

😬 It looks like we might need to up the minimum supported Rust version to 1.36.0 according to https://doc.rust-lang.org/edition-guide/rust-next/maybe-uninit.html

This is due to gpio_cdev's usage of maybe_uninit:

https://github.com/rust-embedded/linux-embedded-hal/pull/55/checks?check_run_id=1874086666

bors[bot] commented 3 years ago

Build succeeded: