rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
232 stars 40 forks source link

Implementation of embedded_hal::digital::IoPin #60

Closed MorganR closed 2 years ago

MorganR commented 3 years ago

This is just a draft, and is pending the PR merge of an IoPin implementation into embedded_hal.

I've verified it with a no-std DHT11 driver based on the IoPin PR.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

MorganR commented 3 years ago

This has been updated to match the definition of IoPin as merged in embedded_hal PR 269.

MorganR commented 3 years ago

Hey folks, I've added a commit to remove the try_ prefixes so this can build against the embedded-hal HEAD. Would you rather merge it like this, or wait until embedded-hal pushes the next alpha release?

eldruin commented 3 years ago

Thanks! It would be better only to depend on released versions of embedded-hal.

eldruin commented 2 years ago

@MorganR Could you update this PR now that I updated this repository to embedded-hal 1.0.0-alpha.5?

MorganR commented 2 years ago

Absolutely, I'll update it by the end of the weekend

bors[bot] commented 2 years ago

Build succeeded:

eldruin commented 2 years ago

@MorganR FYI this is published as part of the 0.4.0-alpha.1 release.