Closed MorganR closed 3 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Done
When an output pin is in active-low mode, the try_set_low and try_set_high functions currently incorrect behavior.
In keeping with the input behavior for
try_is_high
andtry_is_low
, "high" and "low" should refer to the actual output voltage. This works as expected for pins that are not in active-low mode, but if a pin is in active-low mode, then the opposite happens:try_set_low
sets the voltage hightry_set_high
sets the voltage lowThis bug and the fix have been verified using this test program.