Updates for v0.3.x - Githubissues

rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices

Apache License 2.0

232 stars 40 forks source link

Closed eldruin closed 2 years ago

eldruin commented 2 years ago

Fixes #64

rust-highfive commented 2 years ago

r? @posborne

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive commented 2 years ago

:warning: Warning :warning:

Pull requests are usually filed against the master branch for this repo, but this one is against v0.3.x. Please double check that you specified the right target!

eldruin commented 2 years ago

Yeah, the MSRV is effectively broken due to the bitflags dependency. The MSRV is now actually 1.46.0. I guess we have three alternatives here:

Raise MSRV and release 0.3.1. a.k.a. acknowledge status-quo
Raise MSRV and release this as 0.4.0. (0.3 stays broken. Weird for people using 0.4.0-alpha.0)
Do not release this: 0.3 stays broken until we publish 0.4, which may take a long time.

Given the current situation and that not a single issue has been opened due to the broken state of the MSRV, I would go with 1.

nastevens commented 2 years ago

@eldruin I agree - 1 seems like the most generally useful move.

eldruin commented 2 years ago

bors try

bors[bot] commented 2 years ago

Build succeeded:

eldruin commented 2 years ago

The current state of this PR represents option 1 now and can be merged for a 0.3.1 release

eldruin commented 2 years ago

bors r=ryankurte

bors[bot] commented 2 years ago

Build succeeded: