rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
236 stars 40 forks source link

Update embedded-hal to 1.0.0-alpha.8 #83

Closed kelnos closed 2 years ago

rust-highfive commented 2 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

Please see the contribution instructions for more information.

kelnos commented 2 years ago

Looks like embedded-hal 1.0.0-alpha.8 uses include_str!() for doc inclusion, which doesn't appear to be available in rust 1.46.0. I'm fine changing the MSRV; what would you suggest is a good target for it?

har7an commented 2 years ago

Hello,

is there any progress on this?

eldruin commented 2 years ago

Thanks for the reminder. Updating the MSRV to version 1.54.0 would make sense, since that is the version that embedded-hal 1.0 will have (at this time, may increase further).

kelnos commented 2 years ago

Ok, 1.54.0 it is!

eldruin commented 2 years ago

Thanks! Could you also update the MSRV in the bors.toml file? otherwise this will not merge

kelnos commented 2 years ago

Could you also update the MSRV in the bors.toml file? otherwise this will not merge

Done!

kelnos commented 2 years ago

Could you also add an entry to the changelog?

Done

bors[bot] commented 2 years ago

Build succeeded: