rust-embedded / linux-embedded-hal

Implementation of the `embedded-hal` traits for Linux devices
Apache License 2.0
232 stars 40 forks source link

serial: Replace the serial-rs crate with serialport-rs #89

Closed qrasmont closed 1 year ago

qrasmont commented 1 year ago

Replace the unmaintained serial-rs crate with serialport-rs. Closes #86

qrasmont commented 1 year ago

Thank you! Could you add the libudev-dev package here and also add an entry to the changelog?

I chose to remove the dependency to libudev-sys (by disabling default features for the serialport-rs crate) because cross compilation would rely on a pkg-config config with a sysroot for the target (see readme) which complicates the setup for CI and usage. Especially since as described here, the impact of disabling this dependency sums up as : "Enumeration will still be available [...], but won't expose as much information and may return ports that don't exist physically."

This would not be necessary if this PR got merged into libudev-sys: https://github.com/dcuddeback/libudev-sys/pull/8

bors[bot] commented 1 year ago

Build succeeded: