Switch from travis to Github Actions and setup bors

rust-embedded / nb

Minimal and reusable non-blocking I/O layer

Apache License 2.0

86 stars 15 forks source link

Switch from travis to Github Actions and setup bors #23

Closed therealprof closed 4 years ago

therealprof commented 4 years ago

Signed-off-by: Daniel Egger daniel@eggers-club.de

eldruin commented 4 years ago

I think this should only build on stable but not attempt to run the tests since they need nightly.

therealprof commented 4 years ago

Yeah, need to make the tests conditional somehow. This is clearly less than ideal to have CI depend on a nightly version.

therealprof commented 4 years ago

@ryankurte @ithinuel Can I get an approval here?

eldruin commented 4 years ago

Yes. One thing that bugs me specially is that await! includes yield in its expansion and I am not sure what kind of error you would get if attempting to use it on Rust stable. Probably something pretty weird. I will have a look at adding a build.rs to only include it on nightly.

therealprof commented 4 years ago

@eldruin You should be able to approve this now. Want to give it a try? ;)