search

rust-embedded / nb

Minimal and reusable non-blocking I/O layer
Apache License 2.0
86 stars 15 forks source link

Document current MSRV #30

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

This documents the MSRV used in CI, however, this crate builds with a much older Rust version. Would there be interest in lowering it?

therealprof commented 4 years ago

Well, the MSRV is not too useful as long as we support "unstable". Depending on consensus whether we would like to remove the unstable bits I'd be fine with 1.35.

eldruin commented 4 years ago

Ok, now that unstable is out: I think 1.35 MSRV should be fine. Nobody has commented here saying that they would need an older version and anyway further lowering it if somebody really really needs it is non-breaking so we are good.

For the record, the tests run with Rust >= 1.34 due to Infallible and the code itself builds fine with a much older Rust version.

bors[bot] commented 4 years ago

Build succeeded: