search

rust-embedded / nb

Minimal and reusable non-blocking I/O layer
Apache License 2.0
86 stars 15 forks source link

Remove unstable feature and code and modernize #32

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

The tests can now be run on Rust >= 1.34.0 (due to Infallible). Closes #28

eldruin commented 4 years ago

Can I get a review here @rust-embedded/hal ? BTW I discovered that the commit of the 0.1.2 release was not merged into master. I have done that here as well.

therealprof commented 4 years ago

@eldruin As mentioned here: https://github.com/rust-embedded/nb/pull/28#issuecomment-651970273 we said we would wait a few days for objections before executing.

eldruin commented 4 years ago

Great. Should be solved now.

therealprof commented 4 years ago

Would you like to keep the 11 commits or condense this a bit more? (No request, just a question)

I think we'll wait until tomorrow and then I'll pull the trigger.

eldruin commented 4 years ago

Hmm I could squash them but then we would lose the info about the merged 0.1.2 release commit, since I discovered that too late. I could squash around that in a new branch with cherry picking and so on but honestly it feels like busy work.

therealprof commented 4 years ago

@eldruin Hah, you could use that opportunity to learn about git rebase -i. ;)

eldruin commented 4 years ago

Ok I've squashed them now.

bors[bot] commented 4 years ago

Build succeeded: