Closed purplethunder closed 11 months ago
I don't think we should accept this PR, instead we should upgrade riscv to the newest release candidate. Would you mind PRing that instead?
Hmm... maybe we need to bump riscv-rt to 1.60?
You will probably also need to update the CI to make it pass: https://github.com/rust-embedded/riscv/blob/f8c39238c815af9ca92ce945c0dc4ab83c58a004/.github/workflows/riscv-rt.yaml#L14
1.60.0 appears to be problematic as well.
Seems that the issue comes with riscv-target
, used for building the riscv-rt
crate and check the different RISC-V extensions...
I'll try to develop a quick solution to stop using this dependency and allow us to leave the MSRV to 1.60
@purplethunder check #160 and use my commit to get rid of the riscv-target
build dependency. I think with that you should be able to pass the CI
Closing as #160 now solves this
embedded-hal 1.0.0-rc.2 introduced backwards incompatible changes that break riscv builds. This change pins the crate to 1.0.0-rc.1.