rust-embedded / rust-embedded.github.io

A collection of books and other documents about embedded Rust
https://docs.rust-embedded.org
Apache License 2.0
84 stars 8 forks source link

Images are broken in the discovery book #4

Closed japaric closed 6 years ago

japaric commented 6 years ago

At least in the bookshelf version. See:

https://rust-embedded.github.io/bookshelf/discovery/04-meet-your-hardware/index.html

The standalone version of the discovery book does show the images:

https://rust-embedded.github.io/discovery/04-meet-your-hardware/README.html

therealprof commented 6 years ago

cf. https://github.com/rust-embedded/book/pull/38

adamgreen commented 6 years ago

I was playing around with linkchecker tonight to see if I could see why it doesn't detect these missing image URLs. It seems like it treats the absolute links as external links so doesn't bother to check them. I was able to get it to detect the bad links by using this command line:

linkchecker --ignore-url "http.*" --check-extern doc

I used the --ignore-url option too since linkchecker gets a bunch of internal errors if it actually tries to validate links to external websites when I ran it on my Ubuntu VM.

adamgreen commented 6 years ago

I have just created PR #9 to address this issue for the bookshelf repository as well.

adamgreen commented 6 years ago

This is now fixed.

adamgreig commented 6 years ago

Thanks @adamgreen!