rust-embedded / rust-i2cdev

Rust library for interfacing with i2c devices under Linux
Apache License 2.0
205 stars 53 forks source link

Remove build.rs and skeptic from build-deps #47

Closed ryankurte closed 5 years ago

ryankurte commented 5 years ago

This means the readme file is no longer checked for code errors, however the build tree is vastly simplified.

Related to #41, but it didn't seem worth adding a feature for it.

nastevens commented 5 years ago

Instead of completely removing checking of the README, you can actually perform roughly the same tests with rustdoc. Check it out in the fixedvec project: https://github.com/rust-embedded/fixedvec-rs/blob/master/.travis.yml#L30

ryankurte commented 5 years ago

Ahh, that's a neat approach! I moved the example to the rustdocs so it gets tested every time, but can revert that and only test in CI if you'd prefer.

posborne commented 5 years ago

LGTM; merging (haven't gotten around to setting up bors on this; I can fixup the osx no-op build when I get around to that as well).