search

rust-embedded / rust-i2cdev

Rust library for interfacing with i2c devices under Linux
Apache License 2.0
205 stars 53 forks source link

bump nix to 0.14 to fix libc issues #49

Closed ryankurte closed 5 years ago

ryankurte commented 5 years ago

~Waiting on: https://github.com/nix-rust/nix/issues/1060#issuecomment-494627579~ See also: https://github.com/rust-embedded/linux-embedded-hal/pull/17 Patching up to git source tested to be working

rust-highfive commented 5 years ago

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

juliangaal commented 5 years ago

FYI: solution suggested here may not work. This should fix the issue, until this pr is merged 

[patch.crates-io]
i2cdev = { git = "https://github.com/ryankurte/rust-i2cdev" }
ryankurte commented 5 years ago

@posborne nix 0.14.x has landed and CI seems happy ^_^

drinkdhmo commented 5 years ago

Should the version number also be bumped to 0.4.2?

posborne commented 5 years ago

This project hasn't been updated to declare and test against a MSRV formally (https://github.com/rust-embedded/wg/blob/master/ops/msrv.md). I believe from 0.11 -> 0.14 of nix certainly would change the implicit MSRV which would warrant a "major" version bump (0.4 -> 0.5) as I understand it.

It certainly seems annoying to have a major bump for this but this crate does have decent fan-in from other published crates and I am hesitant to possibly break the MSRV of other crates and projects so I believe the correct change here is to go to 0.5 with an MSRV for the new version of 1.24.1 based on the nix MSRV @ 0.14.

posborne commented 5 years ago

I'm willing to go with the MSRV from sysfs-gpio of 1.26.0 as the "implied" MSRV right now. The MSRV for nix is 1.24.1 for 0.14 so I think this is OK.

posborne commented 5 years ago

bors r+

^^^ TODO: repo hasn't been borsified yet.