search

rust-embedded / rust-i2cdev

Rust library for interfacing with i2c devices under Linux
Apache License 2.0
205 stars 53 forks source link

Refactoring + some simplifications #53

Closed eldruin closed 4 years ago

eldruin commented 4 years ago

I have done some refactoring and small code simplifications.

rust-highfive commented 4 years ago

r? @nastevens

(rust_highfive has picked a reviewer for you, use r? to override)

eldruin commented 4 years ago

Yes, build and test is warning-free. Clippy still warns about a couple details but one of them could be understood as documentation (binding new variable, then returning it) and there are a couple unnecessarily-mutable references but in unsafe code so I was not sure if they were intentional.