search

rust-embedded / rust-i2cdev

Rust library for interfacing with i2c devices under Linux
Apache License 2.0
205 stars 53 forks source link

Switch to BigEndian #60

Closed aeubanks closed 4 years ago

aeubanks commented 4 years ago

I'm seeing that the u16s I write and read are big endian, which has bitten me twice. According to various places on the Internet, it should be big endian.

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

aeubanks commented 4 years ago

Never mind, ignore this PR, sorry for the noise. This doesn't actually fix my issues since my code goes through the stuff in linux.rs/ffi.rs. Should have tested before sending out this PR.