search

rust-embedded / rust-sysfs-gpio

A Rust Interface to the Linux sysfs GPIO interface (https://www.kernel.org/doc/Documentation/gpio/sysfs.txt)
Apache License 2.0
383 stars 45 forks source link

Incompatible with tokio crate #50

Closed kaojo closed 5 years ago

kaojo commented 6 years ago

Hi,

i want to use the PinValueStreams together with the newer version of tokio but if i try to use the API, I of course get the following compiler error: "expected struct tokio_core::reactor::Handle, found struct tokio::reactor::Handle"

For now I will just use the AsyncPinPoller and construct the PinValueStream myself. Would it be possible to add support for the "tokio" crate and remain backwards compatibility ?

nastevens commented 6 years ago

The tokio crate is the new standard way of interacting with Tokio, and I believe that the API is meant to be stable until it migrates to futures > 0.1. @kaojo if you want to take a crack at a PR for updating to use tokio directly, I think it would be valuable.

vlvrd commented 5 years ago

@kaojo @nastevens hi, I think this issue should be closed. :space_invader: