search

rust-embedded / rust-sysfs-gpio

A Rust Interface to the Linux sysfs GPIO interface (https://www.kernel.org/doc/Documentation/gpio/sysfs.txt)
Apache License 2.0
383 stars 45 forks source link

Fix feature name tokio->use_tokio in travis config #62

Closed pheki closed 4 years ago

pheki commented 4 years ago

After finding the regression I fixed in #61 I was very surprised that travis managed to compile #60 just fine on macOS (stable) and tried building it on my machine (which failed).

Then I realised that the config file was using --features tokio instead of use_tokio.

rust-highfive commented 4 years ago

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

nastevens commented 4 years ago

~I also built #60 on a Linux box but forgot the use_tokio feature. Should we maybe change this to --all-features in CI to avoid this problem in the future?~ On second thought, it looks like CI is specifically using the features to make sure that a normal build (without tokio) will still build. So I think what you have here is good 👍