search

rust-embedded / rust-sysfs-gpio

A Rust Interface to the Linux sysfs GPIO interface (https://www.kernel.org/doc/Documentation/gpio/sysfs.txt)
Apache License 2.0
383 stars 45 forks source link

Bump async dependencies #69

Closed oll3 closed 3 years ago

oll3 commented 3 years ago

Bumped tokio, mio and futures to recent versions. Took some inspiration from the previous gpio-cdev tokio work and also picked some parts from #60.

Not tested the mio parts but the tokio example (from #60) seems to be working.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

Please see the contribution instructions for more information.

eldruin commented 3 years ago

Thank you very much! CI failed now just because of an unused import. Could somebody else review this @rust-embedded/embedded-linux? Maybe @ryankurte?

oll3 commented 3 years ago

CI failed now just because of an unused import.

Fixed the unused import (and squashed it to the previous commit).

oll3 commented 3 years ago

CI failed now just because of an unused import.

Fixed the unused import (and squashed it to the previous commit).

...and another fix for the mio-evented feature added :eyes:

oll3 commented 3 years ago

Changes LGTM, I think the only thing I would like to see updated is to bump the version in Cargo.toml and look to identify the new MSRV as I suspect these changes impact the minimum supported rust version.

Tokio has MSVR at 1.45 and rust-sysfs-gpio says 1.46 in README.md so it's probably fine as it is. Should bumping of crate version be in this PR, 0.6.0?

bors[bot] commented 3 years ago

Timed out.