rust-embedded / rust-sysfs-pwm

Linux PWM Access via Sysfs in Rust
Apache License 2.0
47 stars 16 forks source link

Handling errors from closure in function `with_exported` #14

Closed Andful closed 3 years ago

Andful commented 3 years ago

This change makes sure that with_exported handles both possible errors from closure() and self.unexport()

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

posborne commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: