search

rust-embedded / rust-sysfs-pwm

Linux PWM Access via Sysfs in Rust
Apache License 2.0
47 stars 16 forks source link

Added asynchronous pwm functionality #25

Open lucaVuitton opened 10 months ago

eldruin commented 10 months ago

Putting it in a separate crate seems fine to me since at least the current version does not share anything with the blocking version other than the error type. If doing so, I would convert this repository to a workspace and have two folders like sysfs-pwm and sys-pwm-async like we do over at embedded-hal. If you need help with the restructuring, let me know.

lucaVuitton commented 10 months ago

Putting it in a separate crate seems fine to me since at least the current version does not share anything with the blocking version other than the error type.

How would I go about doing that?

nastevens commented 10 months ago

How would I go about doing that?

Hey sorry for the delay @lucaVuitton, I had planned to make this change but there's been some things in my personal life that are taking priority. If you want to take a try at it, a good place to start would be looking at the structure of the Cargo.toml files in https://github.com/rust-embedded/embedded-hal. There is a top workspace Cargo.toml, and then each subcrate (sysfs-pwm and sysfs-pwm-async) would get their own subdirectories with Cargo.toml files of their own. If you're okay waiting I'll also get back to this as soon as I can. Thanks!