search

rust-embedded / rust-sysfs-pwm

Linux PWM Access via Sysfs in Rust
Apache License 2.0
47 stars 16 forks source link

Minor fixes #3

Closed ekmecic closed 5 years ago

ekmecic commented 7 years ago

Hello,

I've used the rust-embedded crates as a base for my own work so it's only fair I contribute something back. I've made a few fixes and updates to the code, most significantly using ? over try!.

Let me know if there's any problems or anything you want changed and I'd be happy to help.

posborne commented 5 years ago

@ekmecic Sorry for missing this when it first came in (a very long time ago) and thanks @Disasm for the ping.

CI is failing as the MSRV (Minimum Supported Rust Version) from when major work was done on this crate was quite awhile ago. In general, I think the changes look good assuming they still apply (GH indicates they do). There's a couple minor format things I see but this whole codebase probably needs a rustfmt pass now that that has stabilized so no need to gait on that.

I'm going to go ahead and get this pulled in and will follow up with subsequent changes to deal with the MSRV and formatting.