rust-embedded / svd2rust

Generate Rust register maps (`struct`s) from SVD files
Apache License 2.0
687 stars 149 forks source link

feat: add argument feature_group #617

Closed duskmoon314 closed 2 years ago

duskmoon314 commented 2 years ago

Add new feature feature_group

close #614

rust-highfive commented 2 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

Please see the contribution instructions for more information.

adamgreig commented 2 years ago

Thanks for this PR! We discussed it a bit further at the meeting this evening and a couple of points were raised:

duskmoon314 commented 2 years ago

perhaps outputting a features.toml snippet that crate authors can copy into their Cargo.toml is simpler

I agree. Previously, I just wanted to make it easier to use. But I think it is unexpected behavior for most users when trying to use this feature. I will change it soon.

maybe --group-features or --feature-group would be more obvious

Sure. It is indeed long. 🤣

burrbull commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: