Closed duskmoon314 closed 2 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.
Please see the contribution instructions for more information.
Thanks for this PR! We discussed it a bit further at the meeting this evening and a couple of points were raised:
toml_edit
adds quite a bit to the compile time (and modifying Cargo.toml may surprise some users?), perhaps outputting a features.toml
snippet that crate authors can copy into their Cargo.toml is simpler? We don't otherwise generate or interact with the crate's Cargo.toml.--group-features
or --feature-group
would be more obvious?perhaps outputting a
features.toml
snippet that crate authors can copy into their Cargo.toml is simpler
I agree. Previously, I just wanted to make it easier to use. But I think it is unexpected behavior for most users when trying to use this feature. I will change it soon.
maybe
--group-features
or--feature-group
would be more obvious
Sure. It is indeed long. 🤣
bors r+
Add new feature
feature_group
groupName
features.toml
containing allgroupName
close #614