search

rust-embedded / svd2rust

Generate Rust register maps (`struct`s) from SVD files
Apache License 2.0
687 stars 149 forks source link

Make binary dependencies optional #619

Closed Shatur closed 2 years ago

Shatur commented 2 years ago

Users can now disable binary dependencies if they don't need them, closes #618.

I think we could also make JSON and YAML optional and keep them enabled by default. What do you think?

rust-highfive commented 2 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

Please see the contribution instructions for more information.

Shatur commented 2 years ago

I think we could also make JSON and YAML optional and keep them enabled by default.

What do you think about this suggestion in a separate PR if we merge this?

Emilgardis commented 2 years ago

What do you think about this suggestion in a separate PR if we merge this?

if it's trivial, I think it'd be good to include it here

Shatur commented 2 years ago

if it's trivial, I think it'd be good to include it here

Looks like so, done.

Shatur commented 2 years ago

asking for one more reviewer before merging

@Emilgardis sorry for bothering, but maybe ping someone who can left an additional review?

Shatur commented 2 years ago

@Emilgardis could you please draft a new release after merge?

bors[bot] commented 2 years ago

Build succeeded: