search

rust-embedded / svd2rust

Generate Rust register maps (`struct`s) from SVD files
Apache License 2.0
682 stars 149 forks source link

clap4 & irx-config #656

Closed burrbull closed 1 year ago

rust-highfive commented 1 year ago

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

therealprof commented 1 year ago

Looks okay in principle although I'm not super-psyched to rely on a crate which had a total of 453 downloads until now, a good fraction of which caused by this CI...

burrbull commented 1 year ago

cc @Emilgardis

burrbull commented 1 year ago

cc @Emilgardis Updated to clap 4.0

therealprof commented 1 year ago

@Emilgardis Whoops, sorry, didn't notice you left a comment a while ago. Yes, fine by me. @burrbull If you could resolve the conflict...

luojia65 commented 1 year ago

LGTM, maybe I should close my PR then...

burrbull commented 1 year ago

rebased

bors[bot] commented 1 year ago

Build succeeded: