search

rust-embedded / svd2rust

Generate Rust register maps (`struct`s) from SVD files
Apache License 2.0
698 stars 150 forks source link

Why doesn't the CI use `svd2rust-regress`? #689

Open YuhanLiin opened 1 year ago

YuhanLiin commented 1 year ago

The CI script seems to do the exact same thing as svd2rust-regress, so I'm wondering why they're separated.

Emilgardis commented 1 year ago

no real reason but that we haven't gotten to it :)

Some previous discussions on this

https://github.com/rust-embedded/svd2rust/pull/542#issuecomment-934170012

I've previously also mentioned the possibility to use something like bors try --regress to catch changes in prs and print them as comments, with the new github cli I think we can do this easily and improve the experience.

burrbull commented 9 months ago

cc @Emilgardis should CI be replaced with svd2rust-regress test?

Emilgardis commented 9 months ago

I think it could and probably should