Closed Emilgardis closed 10 months ago
Nice!
we need to add retry for curl https://stackoverflow.com/questions/42873285/curl-retry-mechanism
added no changelog
just to make ci happy for now
What status of this?
I still want to implement it, just don't have the time or motivation right now
Header text
it's now possible to do
cargo regress diff --format --base "@v0.30.3" --head "@v0.31.2"
cargo regress diff --format --head "@debug"
etc.
i have one problem with this though, the diff is way to large to be always useful. I think it would be helpful to have a very small default example case that is expected to only emit few changes. Maybe we could even make a query somehow to specify something like "I only want the diff inside mod clusterb
"
What advances of using json here? Yaml looks more clear:
switched to yaml!
Any opinions on the diff? I think I want it in another way, and having it be saved elsewhere other than action logs would be nice, but I don't think a comment works for it and there's no way to create a gist using an organization account (we'd need a rust-embedded
bot account)
Any opinions on the diff? I think I want it in another way, and having it be saved elsewhere other than action logs would be nice, but I don't think a comment works for it and there's no way to create a gist using an organization account (we'd need a
rust-embedded
bot account)
Need someone more powerful. cc @therealprof @adamgreig
@Emilgardis I've made several fixes. See #782
Maybe it is better to merge this PR and make future changes in new PRs?
I think that's fine, I'll cleanup the commits and do the last adjustments before a review to merge
managed to sneak in a bug during the rebase and implementing regress pr
, should be all good now.
🥳
/ci diff pr
lets try it :)
well it works, but it doesn't like the command , will fix
Beginning of revamp for our CI
This pr adds the following new features
svd2rust-regress tests -- --command
cargo regress
->cargo run -p svd2rust-regress --
where
@pr
= version from current pr,@master
= version from master branchon_comment
hook to allow diffing prsthis should output the result in a
<details>
or gistresolves #355