rust-embedded / svd2rust

Generate Rust register maps (`struct`s) from SVD files
Apache License 2.0
675 stars 147 forks source link

fix regress ci problems #783

Closed Emilgardis closed 7 months ago

Emilgardis commented 7 months ago

follow up to #728

Emilgardis commented 7 months ago

/ci diff pr

github-actions[bot] commented 7 months ago

Diff for comment

burrbull commented 7 months ago

Looks like diff downloads SVD twice for baseline and current. Does it?

Emilgardis commented 7 months ago

Yes it does, theres a fixme to fix that https://github.com/rust-embedded/svd2rust/blob/76cd523071a46e3ade63364ece8b418e53290c0d/ci/svd2rust-regress/src/svd_test.rs#L237-L246

The fix would probably be to download once and copy/link to respective output folder, then inside setup_case check if the svd already exists and is "new"