search

rust-embedded / wg

Coordination repository of the embedded devices Working Group
1.86k stars 95 forks source link

Actions-rs is deprecated #754

Open nastevens opened 1 month ago

nastevens commented 1 month ago

Per https://github.com/actions-rs the actions-rs project is deprecated and unmaintained. The associated actions have started to raise numerous warnings and are likely to stop working entirely at some point. An unscientific survey of other Rust projects seems to indicate a migration to https://github.com/dtolnay/rust-toolchain, but I would like to get some consensus from the team before charging ahead with this. This may also be an opportunity to close out #671.

I'm opening this issue here since it affects at least 20 R-E repos across multiple subteams at the time of writing: https://github.com/search?q=org%3Arust-embedded+actions-rs&type=code.

Rahix commented 1 month ago

There is also actions-rust-lang/setup-rust-toolchain but I don't know how the two compare.

newAM commented 1 month ago

It was also pointed out to me that rustup can be used directly, it's included in the ubuntu runner images.

jonathanpallant commented 1 month ago

I prefer to just use rustup.

nastevens commented 1 month ago

Does anyone have repos they can point to as reference of good design using GHA? Bonus points if the repo is already testing a matrix of architectures and features.

Emilgardis commented 1 month ago

svd2rust has a pretty good setup: https://github.com/rust-embedded/svd2rust/blob/6979dc40c2d812b6f4f0b4fc7a18c29233faaf85/.github/workflows/ci.yml#L50

romancardenas commented 1 month ago

In riscv we use rust-toolchain with different targets, features, etc.

So far, it works pretty fine.

jannic commented 1 month ago

I updated several repos to dtolnay/rust-toolchain a while ago, eg.:

Not saying that this is the best approach, only noting that it seems to work well.